Skip to content

fix cc.view resizing #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cruzdanilo
Copy link
Contributor

No description provided.

@pandamicro
Copy link
Contributor

Hi, which case does your modification fix ? The default value is set to true to avoid useless adaptation logic when launching

@cruzdanilo
Copy link
Contributor Author

i'm using the browser, and _orientationChanging is not set to false anywhere. this is breaking the use of cc.view.resizeWithBrowserSize.

    _resizeEvent: function () {
        var view;
        if (this.setDesignResolutionSize) {
            view = this;
        } else {
            view = cc.view;
        }
        if (view._orientationChanging) {
            return;
        }

@pandamicro
Copy link
Contributor

You mean desktop browser ?

@cruzdanilo
Copy link
Contributor Author

yes

@iborusik
Copy link

Yes, pls apply this PR. This issue happens on desktop if "cc.view.resizeWithBrowserSize" is settled to "true".

@pandamicro
Copy link
Contributor

@iborusik Thanks for fixing this

@cruzdanilo cruzdanilo closed this Oct 29, 2017
@cruzdanilo cruzdanilo deleted the fix-resize branch October 29, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants